1357: Viewport is OffByOne

Discussion related to "Everything" 1.5 Alpha.
Post Reply
therube
Posts: 4979
Joined: Thu Sep 03, 2009 6:48 pm

1357: Viewport is OffByOne

Post by therube »

1357: Viewport ... what else to say, oh, don't know...

(on an overflow)

when you arrow-key down the viewport
you cannot "access" the last entry shown

as in, cursor focus will always be viewport height (depth) -1

you can /see/ the last entry,
but you have to click down to "access" it
(& so once again you can /see/ the next entry, but cannot "access" it)


- oh, so this also why if (on overflow) you END [key], you (now)
see 2 whitespaces (vs. prior, only 1)


- similarly, say you are 1 line before end of viewport
(end of results list, such that 1 result is yet to come into focus)
& you rename a pair of files in the middle of viewport
on rename, viewport "jumps", & at that point
- while /selection/ has not changed
the viewport "jumped", now showing 1 whitespace


Off By One ;-)
.
Attachments
OffByOne.png
OffByOne.png (32.26 KiB) Viewed 8425 times
void
Developer
Posts: 16764
Joined: Fri Oct 16, 2009 11:31 pm

Re: 1357: Viewport is OffByOne

Post by void »

Thanks for the issue report therube,

Does resizing the window fix the problem?

Could you please send a screenshot after pressing the down arrow to support@voidtools.com
void
Developer
Posts: 16764
Joined: Fri Oct 16, 2009 11:31 pm

Re: 1357: Viewport is OffByOne

Post by void »

Does this issue occur if you don't add a new tab?
therube
Posts: 4979
Joined: Thu Sep 03, 2009 6:48 pm

Re: 1357: Viewport is OffByOne

Post by therube »

Does this issue occur if you don't add a new tab?
No.
It only happens when you have Tabs visible.
Does resizing the window fix the problem?
I tend to keep static sizes, so not sure offhand.
Could you please send a screenshot after pressing the down arrow
And yet again, this is another issue where I see discrepancies in behaviors (between Everything on different systems), & I'm not sure why?
(System configurations are too alike, so I'm thinking it is not that. Perhaps it happens to be just dumb luck sizing?)
therube
Posts: 4979
Joined: Thu Sep 03, 2009 6:48 pm

Re: 1357: Viewport is OffByOne

Post by therube »

1. hi
2. scrolled down to "end" of viewport, cannot "access" the 3rd +999.gif
3. hit down-arrow, can now acess 3rd. 999.gif, but now cannot "access" +ccc.gif
4. & so it continues
5. extra whitespace at end of listing
(all above were with Tabs)
6. normal whitespace at end of listing (no Tabs)
7. normal down-arrow action, you /can/ access the final (fully displayed) item, as expected (no Tabs)
.
Everything - Tabs - cannot highlight last entry, extra whitespace2.png
Everything - Tabs - cannot highlight last entry, extra whitespace2.png (527.04 KiB) Viewed 8296 times
void
Developer
Posts: 16764
Joined: Fri Oct 16, 2009 11:31 pm

Re: 1357: Viewport is OffByOne

Post by void »

Thanks for the images therube,

The last item is partially visible.
(even though it looks fully visible -there's one pixel missing)

Resizing the window should fix the issue.
-or-
If you want to avoid resizing your window, consider making the tab height a multiple of your item height:
  • In Everything 1.5, from the Tools menu, click Options.
  • Click the Advanced tab on the left.
  • To the right of Show settings containing, search for:
    tab
  • Select tab_high.
  • Set the value to: 23
  • Click OK.
therube
Posts: 4979
Joined: Thu Sep 03, 2009 6:48 pm

Re: 1357: Viewport is OffByOne

Post by therube »

there's one pixel missing
I have no idea how you saw that.
Glad your eyes are better then mine.
Set the value to: 23
That did it, thanks :-).

consider making the tab height a multiple of your item height
Is that something related to listview_item_high= ?
void
Developer
Posts: 16764
Joined: Fri Oct 16, 2009 11:31 pm

Re: 1357: Viewport is OffByOne

Post by void »

consider making the tab height a multiple of your item height
Is that something related to listview_item_high= ?
Yes.
listview_item_high sets the listview item height in logical pixels.
therube
Posts: 4979
Joined: Thu Sep 03, 2009 6:48 pm

Re: 1357: Viewport is OffByOne

Post by therube »

In my case, both settings were at the (I suppose ?) default of 0.
void
Developer
Posts: 16764
Joined: Fri Oct 16, 2009 11:31 pm

Re: 1357: Viewport is OffByOne

Post by void »

The default for listview_item_high and tab_high is: 0

When set to zero, the height is calculated from the font height.
therube
Posts: 4979
Joined: Thu Sep 03, 2009 6:48 pm

Re: 1358: Change

Post by therube »

With 1358:

< tab_high=23

changed to:

> tabs_high=22
Post Reply