Visual bug with sorting when alternate row colors is enabled (v1371)

[Lucane]

When the "alternate row colors" option is enabled, sorting by a column results in row colors being offset relative to other columns.

Below are comparison images between v1.4 and v1.5.
In v1.5 the 'Size' column row colors are displayed incorrectly.

Everything v1.4.1.1024


Everything v1.5.0.1371a

[NotNull]

This is what it looks like here:

2024-04-08 22_36_41-Everything (1.5a) 1.5.0.1371a (x64).png (29.47 KiB) Viewed 629 times

The alternating row colors of the sorted column are configurable:

- go to Menu => Tools => Options => General => Fonts and colors
- Theme = Dark
- Item = Result list
- Select Current Sort Alternate Row from the Item States list
- Configure colours to your liking

[Lucane]

Thank you, that worked. I had to additionally change the background color for "Current Sort".

After fiddling around for a bit it seems that the same behaviour is present in the stable v1.4 release, but I just haven't noticed it before.

Probably not something that's worth fixing, but I thought I'd at least do a write-up in case someone wants to look into it further some day.



This behaviour seems to primarily occur with darker colors. It's as if the calculation in the code that derives the default color values for 'Current Sort' and 'Current Sort Alternate Row' breaks down when the colors are too dark - as if the color values get swapped around.

These are the default color values that I get (all except 'Normal', which is a custom color - all others are derived colors):

• Normal - HSL(144, 43, 39)
• Alternate Row - HSL(143, 44, 51)
• Current Sort - HSL(143, 44, 61)
• Current Sort Alternate Row - HSL(144, 44, 46)

When I swap the 'Current Sort' and 'Current Sort Alternate Row' colors manually, then the colors look accurate.
This is what it looks like when I swap those two color values (I'm using the default color values of each respective setting, but they've been swapped):





This happens with other colors as well (I've only changed the 'Normal' background color here, others are set on default):







But other colors don't produce this behaviour (seems to only affect darker colors):

[void]

Thank you for bringing this issue to my attention.

Everything tries to use a darker alternate row color/current sort color when the normal background is light.

Everything considers the normal background color as "light" in your examples with the visual bug.

The next alpha alpha will always treat the color as "dark" when in dark theme.

[void]

Everything 1.5.0.1372a will now always use a lighter color for the alternate row/current sort/mouseover color in the dark theme.

[Lucane]

Thank you for implementing this fix! I can confirm that the colors are displayed correctly now.