Some items missed from Undo History - perhaps LFN

[therube]

Some items missed from Undo History - perhaps LFN?

Everything 1386 x86

Undo History changes missing

Code: Select all

renamed a file
	orig: .......................................................................				(SFN)
	 ren: .............................................................................
	 ren: ......................................................................................
	 ren: .........................................................................................
  	 ren: ................................................................................................	(SFN)
then, another rename shows, but the Name & New Name are the same, so there was no "rename"
  	 ren: ................................................................................................
(maybe ? that relates to the undo, not sure)
then, & this does not show - at all - & maybe ? this lack relates to the undo, not sure?
	 ren: T:\NEW\............................................................................................................................................................................................................................................................
at which point, i am now LFN, 253-name + 23-path
at that point, i MOVED the file up the tree
	from: T:\NEW\...............\
	  to: T:\NEW\
finally, Ctrl+Z
	< file not found > (or something along those lines)

yet, the file does exist, LFN in T:\NEW\, the last location/name that it was, prior to the Ctrl+Z attempt

Index Journal, shows MORE data
the last "SFN", 242-chars path+name (presumably coinciding with last Undo record)
then another rename "LFN" at that point
then the move to its current path
Undo, from Index Journal, successfully moved the file back to where it belonged

if i at that point, CUT the file
& (using Everything) right-click its' Path, & (again) move it up the tree

- the file is correctly moved
- that action is NOT recorded in Undo History
- that action IS recorded in Index Journal


orig file name: 123456789^
then i added it 6 or 7x more, so: 123456789^123456789^123456789^123456789^123456789^123456789^123456789^
then i doubled it, so: 123456789^123456789^123456789^123456789^123456789^123456789^123456789^123456789^123456789^123456789^123456789^123456789^123456789^123456789^
then more again, making it a LFN, then backspaced till it "fit"

1. Undo does not have full Undo History
- does NOT show the MOVE
Index Journal does show full History, including the MOVE
2. Undo History, Ctrl-Z to undo the MOVE, fails, because it was never recorded (there)
3. Undo History
- does NOT show Index Journal's MOVE (back to original Path) [maybe it shouldn't, cause it was done outside of Undo's perview?]
Index Journal did correctly Undo the action, moving the file back to its original Path
& Everything itself shows likewise
.

Everything - Undo History Missing Changes.png (284.95 KiB) Viewed 8245 times

keyword: Unable to rename. Error 2: File not found.

[void]

The next alpha update will have support for undoing copies/moves with very long filenames.

Thank you for bringing the issue to my attention.

[therube]

this follows along (& i think it's how it played out)... LFN undo...

Say you CUT a file in Everything
Then PASTE that file, through some other program, & that other program can't deal with LFN,
say instead what gets PASTE is the SFN version of the original LFN,
if you then (in Everything, Index Journal I suppose it would have to be?) went to Undo the action,
you get an Error 2.


oh, so what is happening, with that Error 2
is that with a LFN, when you Paste said file
somewhere (via say Salamander)
the SFN is pasted
& /that/ must be why the Error 2
because Everything wants to undo the (move of a) LFN
but the LFN file no longer exists
- as it was "changed" to a SFN (in order to work around...)
- ah, & it also left "deadwood"

that's a bit of a quandary...

[void]

This is a bug with the USN Journal.

The USN Journal uses the short filename instead of the very long filename.

There's no way for Everything to know the correct filename.
The old long filename will remain in your index until you for a manually reindex.

The Journal Index will show the short filename.
This short name will likely break the undo action.
What was shown in the index journal for this operation?



Error 2 is: File not found

[therube]

What was shown in the index journal for this operation?

file /was/ on T:
(incorrectly) /moved/ to V:
file ended up on V:
"deadwood" (record) [also] left pointing on T:


Undo History, i must have been too quick
(as in, immediately after catching what i did, i did Ctrl+Z, which said "admin priv..."
& then I opened Undo History, & nothing related was there at all)

Index Journal:

Code: Select all

10:12 File Create, Path V:, Size 0   (followed by)
10:12 File Modify, Path V:, Size 307745490

(so it seems that the Create 0, followed by Modify <real size>, is all expected)

[therube]

(rearranged sort order, old to new, & num'd it, from Index Journal)

1. renamed file
2. [initiated] CUT from T & PASTE to V - does "0", mean 0 bytes ? [this was wrong action, which i caught, & "aborted"*]
3. shows a Delete from T (so still wrong)
4. shows a Create /on/ T (so i suppose this is where my abort actually caught things ?)
5. shows a Delete from V (though other then the Create[2],"0", there was no, i'm assuming, actual create on V)
6. <perhaps unrelated>
(at that point, i expected to have "deadwood" on T, but i found that the file was in fact still actually on T)
7. Move - this was my /intended/ action to begin with, to Move from T/NEW/CCC/... to T/NEW/delme/

Code: Select all

"ID","Date","Action","Name","Path","New Name","New Path","Size"
[1]"90233","2024-11-18 19:44:06","File Rename","Tesl","T:\NEW\CCC\C2C2\X2\X\Z\other\2\X\X\222\999","Tesl 4","","286864316"
[2]"90244","2024-11-18 19:44:54","File Create","Tesl 4","V:\NEW\delme","","","0"
[3]"90245","2024-11-18 19:44:55","File Delete","Tesl 4","T:\NEW\CCC\C2C2\X2\X\Z\other\2\X\X\222\999","","",
[4]"90246","2024-11-18 19:44:55","File Create","Tesl 4","T:\NEW\CCC\C2C2\X2\X\Z\other\2\X\X\222\999","","","286864316"
[5]"90247","2024-11-18 19:44:56","File Delete","Tesl 4","V:\NEW\delme","","",
[6]"90249","2024-11-18 19:44:58","File Create","Tesl 4","E:\Users\RUBEN\AppData\Roaming\Microsoft\Windows\Recent","","","1837"
[7]"90263","2024-11-18 19:45:14","File Move","Tesl 4","T:\NEW\CCC\C2C2\X2\X\Z\other\2\X\X\222\999",,"T:\NEW\delme","286864316"

*aborted
in every case before where i had "caught" [& "aborted" the incorrect action], "something" went wrong
most often, the "move" (delete & newly create, as it was across volumes) DID finish, the file was in fact moved
&, most often, the source (incorrectly) also remained (in Everything, as "dead wood"), though in fact the file source no longer exists

this time, for whatever reason, i was actually able to abort before things got too far along, & the source file remained on source
no deadwood was left behind, (& file date created was unchanged, though date accessed was set to current)

[void]

2. [initiated] CUT from T & PASTE to V - does "0", mean 0 bytes ? [this was wrong action, which i caught, & "aborted"*]

Yes, this really should be 0 and not "0". I'll have this fixed in 1384a+
The file size might be 0 if the file doesn't exist in the current location.
Once Everything syncs up with whats really on disk (the file is modified) the size should match up.

3. shows a Delete from T (so still wrong)

This one is odd to me.
I wonder why the original file was deleted.
I assume it should be deleted, but only after the copying completes.
I assume you abort the copy before it completes.

How are you indexing the T: drive (Tools -> Options -> NTFS or Tools -> Options -> Folders?)
Tools -> Options -> Folders updates the database immediately when a move is successfully performed in Everything.
We might be seeing the shell preemptively return success for a move when the real move occurs in the background...

6. <perhaps unrelated>

Unrelated.

[therube]

T: V: E: are all plain jane NTFS indexes.